Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: allow external plugins yum locking ......................................................................
Patch Set 5: Code-Review+1 (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py Line 64: osetupcons.FileLocations.OVIRT_ENGINE_YUM_VERSIONLOCK, Line 65: ) as f: Line 66: for line in f.read().splitlines(): Line 67: found = False Line 68: for check in self.environment[ I'd personally use some other name instead of 'check', 'checks' - perhaps 'pattern' or something like that. Line 69: osetupcons.RPMDistroEnv.VERSION_LOCK_FILTER Line 70: ]: Line 71: if line.find(check) != -1: Line 72: found = True -- To view, visit http://gerrit.ovirt.org/21779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5a33d3a09e1c5aa9fed8a08d81a4ce583c12797 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshum...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
