Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: allow external plugins yum locking
......................................................................
Patch Set 3:
(3 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 1019: )
Line 1020: def REQUIRE_ROLLBACK(self):
Line 1021: return 'OSETUP_RPMDISTRO/requireRollback'
Line 1022:
Line 1023: FILTER_PACKAGES = 'OSETUP_RPMDISTRO/filterPackages'
VERSION_LOCK_ prefix? it is not that clear what filter is.
Line 1024: LOCK_PACKAGES = 'OSETUP_RPMDISTRO/lockPackages'
Line 1025:
Line 1026:
Line 1027: @util.export
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py
Line 69: ]:
Line 70: if line.find(check) != -1:
Line 71: continue
Line 72: content.append(line)
Line 73: modified = True
the modified should be if != -1 I think... no?
Line 74: return (modified, content)
Line 75:
Line 76: @property
Line 77: def environment(self):
Line 304: osetupcons.RPMDistroEnv.FILTER_PACKAGES
Line 305: ].append(osetupcons.Const.ENGINE_PACKAGE_NAME)
Line 306: self.environment[
Line 307: osetupcons.RPMDistroEnv.LOCK_PACKAGES
Line 308: ] += osetupcons.Const.RPM_LOCK_LIST
if you use append... use extend?
Line 309: if self._distribution in ('redhat', 'fedora', 'centos'):
Line 310: self.command.detect('rpm')
Line 311:
Line 312:
self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
--
To view, visit http://gerrit.ovirt.org/21779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a33d3a09e1c5aa9fed8a08d81a4ce583c12797
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Spenser Shumaker <sshum...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
