Alexander Wels has posted comments on this change.
Change subject: webadmin: version in feedback url.
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
Line 112: getView().setFeedbackText(feedbackLinkLabel);
Line 113:
registerHandler(getView().getFeedbackLink().addClickHandler(new ClickHandler() {
Line 114: @Override
Line 115: public void onClick(ClickEvent event) {
Line 116:
WebUtils.openUrlInNewWindow(feedbackLinkLabel, feedbackUrl);
Yes we can easily add that, it is just changing the message in the properties
file. The feedback button should automatically size to the length of the text
of the label, so if it grows it shouldn't affect the rest of the layout.
Line 117: }
Line 118: }));
Line 119: }
Line 120: }
Line 118: }));
Line 119: }
Line 120: }
Line 121: };
Line 122: AsyncDataProvider.getRpmVersionViaPublic(_asyncQuery);
I did not know this existed, good plan to use it.
Line 123: }
--
To view, visit http://gerrit.ovirt.org/21738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
