Einav Cohen has posted comments on this change.
Change subject: webadmin: version in feedback url.
......................................................................
Patch Set 1:
(2 comments)
> @Einav can you answer the question about if we should add the version option
> to the feedback label as well?
done (replied also on the second comment). thanks.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
Line 112: getView().setFeedbackText(feedbackLinkLabel);
Line 113:
registerHandler(getView().getFeedbackLink().addClickHandler(new ClickHandler() {
Line 114: @Override
Line 115: public void onClick(ClickEvent event) {
Line 116:
WebUtils.openUrlInNewWindow(feedbackLinkLabel, feedbackUrl);
Need to keep in mind that we are dealing here with the Feedback button URL, and
not the Feedback button label.
I don't think that we need it in the label at this point (it will also impact
the layout of the top banner, due to the 'lengthy' string).
I think that it is OK to add this ability without actually using it in oVirt;
however, we *can* use it in oVirt as well (e.g. make the URL something like
"mailto:us...@ovirt.org?subject=feedback-on-oVirt-engine-{0}";, where '{0}' is
the version placeholder).
@Alex, what do you think? is that something that we can easily do?
Line 117: }
Line 118: }));
Line 119: }
Line 120: }
Line 118: }));
Line 119: }
Line 120: }
Line 121: };
Line 122: AsyncDataProvider.getRpmVersionViaPublic(_asyncQuery);
maybe use 'getConfigFromCache()'? can save a request to the backend, as we will
fetch from cache, rather than backend.
Line 123: }
--
To view, visit http://gerrit.ovirt.org/21738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
