Doron Fediuck has posted comments on this change.
Change subject: engine: scheduling optimization field
......................................................................
Patch Set 9:
(2 comments)
Last minor fixes needed.
Other than that I'm good with this change.
....................................................
Commit Message
Line 3: AuthorDate: 2013-09-12 17:36:37 +0200
Line 4: Commit: Gilad Chaplik <gchap...@redhat.com>
Line 5: CommitDate: 2013-11-24 10:42:39 +0200
Line 6:
Line 7: engine: scheduling optimization field
Is this patch about a field?
Somehow I thought it introduces an important optimization to the scheduling
sub-system. If this is about a new optimization I suggest you rephrase the
commit message to something like "Adding Speed optimization option to the
scheduler".
Line 8:
Line 9: Add to cluster entity optimization_type field.
Line 10: this field is a binary representation of cluster optimization
possibilities.
Line 11: The first option is optimize for speed, allows to skip host weighing
in case
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 105: MaxVmNameLengthNonWindows(ConfigAuthType.User),
Line 106: AttestationServer,
Line 107: DefaultGeneralTimeZone,
Line 108: DefaultWindowsTimeZone,
Line 109: ParallelSchedulingRequestThreshold;
Parallel? It belongs to a different optimization.
You should probably have here SpeedOptimizationSchedulingThreashold
Line 110:
Line 111: public static enum ConfigAuthType {
Line 112: Admin,
Line 113: User
--
To view, visit http://gerrit.ovirt.org/19270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
