Doron Fediuck has posted comments on this change. Change subject: engine: scheduling optimization field ......................................................................
Patch Set 6: (1 comment) Agree with Roy's comments. Also let's re-use the field this patch adds to the cluster entity to support additional optimization types. See my comment in the sql file. .................................................... File packaging/dbscripts/upgrade/03_04_1000_add_vds_group_scheduling_optimization_field.sql Line 1: select fn_db_add_column('vds_groups', 'optimize_for_speed', 'boolean not null default false'); Since we will have more than one optimization type, let's call this optimization-type with a default of zero (none). -- To view, visit http://gerrit.ovirt.org/19270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0784f89648093e650be73fcc3d850a4854d53c1a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches