Adam Litke has uploaded a new change for review.
Change subject: engine: [cleanup] Rename RunMultipleActions to
runMultipleActions
......................................................................
engine: [cleanup] Rename RunMultipleActions to runMultipleActions
Backend.java:508, NM_METHOD_NAMING_CONVENTION, Priority: Low
The method name
org.ovirt.engine.core.bll.Backend.RunMultipleActions(VdcActionType,
ArrayList, boolean)
doesn't start with a lower case letter
Methods should be verbs, in mixed case with the first letter lowercase,
with the first letter of each internal word capitalized.
Change-Id: I0bfa0221abc1a533f39ec114238b89dbe437164c
Signed-off-by: Adam Litke <ali...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
5 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/21547/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
index fb41f15..d42b216 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
@@ -503,7 +503,7 @@
}
@Override
- public ArrayList<VdcReturnValueBase> RunMultipleActions(VdcActionType
actionType,
+ public ArrayList<VdcReturnValueBase> runMultipleActions(VdcActionType
actionType,
ArrayList<VdcActionParametersBase> parameters, boolean
isRunOnlyIfAllCanDoPass) {
VdcReturnValueBase returnValue = notAllowToRunAction(actionType);
if (returnValue != null) {
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
index 4597e4f..9532eca 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
@@ -45,12 +45,12 @@
updateParameters();
if (!moveDiskParametersList.isEmpty()) {
-
vdcReturnValues.addAll(Backend.getInstance().RunMultipleActions(VdcActionType.MoveOrCopyDisk,
+
vdcReturnValues.addAll(Backend.getInstance().runMultipleActions(VdcActionType.MoveOrCopyDisk,
getParametersArrayList(moveDiskParametersList), false));
}
if (!liveMigrateVmDisksParametersList.isEmpty()) {
-
vdcReturnValues.addAll(Backend.getInstance().RunMultipleActions(VdcActionType.LiveMigrateVmDisks,
+
vdcReturnValues.addAll(Backend.getInstance().runMultipleActions(VdcActionType.LiveMigrateVmDisks,
getParametersArrayList(liveMigrateVmDisksParametersList),
false));
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java
index 62dc3fc..ce33c6f 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java
@@ -40,7 +40,7 @@
return
Backend.getInstance().runInternalMultipleActions(VdcActionType.AddStoragePoolWithStorages,
parameters);
} else {
- return
Backend.getInstance().RunMultipleActions(VdcActionType.AddStoragePoolWithStorages,
+ return
Backend.getInstance().runMultipleActions(VdcActionType.AddStoragePoolWithStorages,
parameters, false);
}
} else {
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
index e711a99..eba6c86 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
@@ -22,7 +22,7 @@
ErrorTranslator getVdsErrorsTranslator();
- java.util.ArrayList<VdcReturnValueBase> RunMultipleActions(VdcActionType
actionType,
+ java.util.ArrayList<VdcReturnValueBase> runMultipleActions(VdcActionType
actionType,
java.util.ArrayList<VdcActionParametersBase> parameters,
boolean isRunOnlyIfAllCanDoPass);
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
index 070c9f2..dc57b5a 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
@@ -110,7 +110,7 @@
}
ArrayList<VdcReturnValueBase> returnValues =
- getBackend().RunMultipleActions(actionType, multipleParams,
isRunOnlyIfAllCanDoPass);
+ getBackend().runMultipleActions(actionType, multipleParams,
isRunOnlyIfAllCanDoPass);
return returnValues;
}
--
To view, visit http://gerrit.ovirt.org/21547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bfa0221abc1a533f39ec114238b89dbe437164c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
