Adam Litke has uploaded a new change for review. Change subject: engine: [cleanup] Rename RunAutoAction to runAutoAction ......................................................................
engine: [cleanup] Rename RunAutoAction to runAutoAction Backend.java:621, NM_METHOD_NAMING_CONVENTION, Priority: Low The method name org.ovirt.engine.core.bll.Backend.RunAutoAction(VdcActionType, VdcActionParametersBase) doesn't start with a lower case letter Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. Change-Id: I6be00cdaf1652659dd73d45f4da281281876e130 Signed-off-by: Adam Litke <ali...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/21549/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java index a06ee7e..04c3bf0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java @@ -617,7 +617,7 @@ } @Override - public VdcReturnValueBase RunAutoAction(VdcActionType actionType, VdcActionParametersBase parameters) { + public VdcReturnValueBase runAutoAction(VdcActionType actionType, VdcActionParametersBase parameters) { return runAction(actionType, parameters); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java index 746db15..363a897 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java @@ -35,7 +35,7 @@ VdcReturnValueBase logoff(LogoutUserParameters parameters); // for auto backend - VdcReturnValueBase RunAutoAction(VdcActionType actionType, VdcActionParametersBase parameters); + VdcReturnValueBase runAutoAction(VdcActionType actionType, VdcActionParametersBase parameters); VdcQueryReturnValue RunAutoQuery(VdcQueryType actionType, VdcQueryParametersBase parameters); } -- To view, visit http://gerrit.ovirt.org/21549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6be00cdaf1652659dd73d45f4da281281876e130 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches