Adam Litke has uploaded a new change for review. Change subject: engine: [cleanup] Rename Initialize to initialize ......................................................................
engine: [cleanup] Rename Initialize to initialize Backend.java:171, NM_METHOD_NAMING_CONVENTION, Priority: Low The method name org.ovirt.engine.core.bll.Backend.Initialize() doesn't start with a lower case letter Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. Change-Id: I2b48a9368fedd5da6eea764b773785e6df16db23 Signed-off-by: Adam Litke <ali...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/44/21544/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java index 2862d02..a5f428a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java @@ -126,7 +126,7 @@ @PostConstruct public void create() { checkDBConnectivity(); - Initialize(); + initialize(); } private static void checkDBConnectivity() { @@ -167,7 +167,7 @@ * <exception>VdcBLL.VdcBLLException */ @Override - public void Initialize() { + public void initialize() { log.info("Start initializing " + getClass().getSimpleName()); // When getting a proxy to this bean using JBoss embedded, the initialize method is called for each method // invocation on the proxy, as it is called by setup method which is @PostConstruct - the initialized flag diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java index 958f820..cf0f87e 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java @@ -26,7 +26,7 @@ java.util.ArrayList<VdcActionParametersBase> parameters, boolean isRunOnlyIfAllCanDoPass); - void Initialize(); + void initialize(); VdcQueryReturnValue RunPublicQuery(VdcQueryType actionType, VdcQueryParametersBase parameters); -- To view, visit http://gerrit.ovirt.org/21544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2b48a9368fedd5da6eea764b773785e6df16db23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches