Kanagaraj M has posted comments on this change.
Change subject: engine : Rebalance status to show Started and Stopped At fields
......................................................................
Patch Set 16:
(5 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java
Line 134:
getStopTime().setEntity(rebalanceStatusEntity.getStopTime());
Line 135: }
Line 136: }
Line 137: }
Line 138:
setStopTimeAvailable(rebalanceStatusEntity.getStatusSummary().getStatus() ==
JobExecutionStatus.ABORTED);
this could be moved to above if block
Line 139: if (GlusterTaskType.REBALANCE ==
getEntity().getAsyncTask().getType()) {
Line 140:
getStopReblanceFromStatus().setIsExecutionAllowed(rebalanceStatusEntity.getStatusSummary().getStatus()
== JobExecutionStatus.STARTED);
Line 141: }
Line 142: }
Line 183: private boolean stopTimeVisible;
Line 184:
Line 185: private void setStopTimeAvailable(boolean available) {
Line 186: setStopTimeVisible(available);
Line 187: onPropertyChanged(new
PropertyChangedEventArgs("STOP_TIME_UPDATED"));//$NON-NLS-1$
This could be moved to setStopTimeVisible. and you can remove this method.
Also compare the existing value of stopTimeVisible with new value, and decide
to raise onPropertyChanged
Line 188: }
Line 189:
Line 190: public UICommand getStopReblanceFromStatus() {
Line 191: return stopReblanceFromStatus;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 112: }
Line 113:
Line 114: private void setVisibilities() {
Line 115: status.setVisible(false);
Line 116: }
this method is not being used
Line 117:
Line 118: private void localize(final ApplicationConstants constants) {
Line 119: startTimeEditor.setLabel(constants.rebalanceStartTime());
Line 120: volumeEditor.setLabel(constants.rebalanceVolumeName());
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.ui.xml
Line 20: }
Line 21:
Line 22: .stopTime {
Line 23: padding-top: 30px;
Line 24: }
fix the indentation
Line 25: .messageLabel {
Line 26: color: #FF0000;
Line 27: left: 10px;
Line 28: padding-top: 5px;
Line 46:
<e:EntityModelLabelEditor ui:field="statusTimeEditor" />
Line 47: </g:VerticalPanel>
Line 48: <g:VerticalPanel>
Line 49: <g:Label ui:field="status"
addStyleNames="{style.labelStyle}"/>
Line 50: </g:VerticalPanel>
remove whitespace
Line 51: </g:HorizontalPanel>
Line 52: <g:ScrollPanel
addStyleNames="{style.tablePanel}"
Line 53: ui:field="sPanel">
Line 54: <e:EntityModelCellTable
ui:field="rebalanceHostsTable" />
--
To view, visit http://gerrit.ovirt.org/20800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2957ba2c4bd1f6deb1ef444e28e8afdd8896f0b4
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
