Kanagaraj M has posted comments on this change.
Change subject: engine : Rebalance status to show Started and Stopped At fields
......................................................................
Patch Set 13:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java
Line 192: if (available) {
Line 193: onPropertyChanged(new
PropertyChangedEventArgs("STOP_TIME_IS_APPLICABLE"));//$NON-NLS-1$
Line 194: } else {
Line 195: onPropertyChanged(new
PropertyChangedEventArgs("STOP_TIME_NOT_APPLICABLE"));//$NON-NLS-1$
Line 196: }
instead of having two propertychange events for a single field,
have a single properychange "STOP_TIME_UPDATED", then have a boolean field in
the model. In the view, use this boolean field to decide the visibility
Line 197: }
Line 198:
Line 199: public UICommand getStopReblanceFromStatus() {
Line 200: return stopReblanceFromStatus;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.ui.xml
Line 35:
<e:EntityModelLabelEditor ui:field="volumeEditor" />
Line 36:
<e:EntityModelLabelEditor ui:field="startTimeEditor" />
Line 37: </g:VerticalPanel>
Line 38: <g:VerticalPanel
ui:field="stopTimePanel">
Line 39: <e:EntityModelLabelEditor
ui:field="fillerEditor" />
why this required?
You could use "padding-top" if you want to align stopTimeEditor
Line 40: <e:EntityModelLabelEditor
ui:field="stopTimeEditor" />
Line 41: </g:VerticalPanel>
Line 42: <g:VerticalPanel>
Line 43:
<e:EntityModelLabelEditor ui:field="clusterEditor" />
Line 44:
<e:EntityModelLabelEditor ui:field="statusTimeEditor" />
Line 45: </g:VerticalPanel>
Line 46: <g:VerticalPanel>
Line 47: <g:Label ui:field="status"
addStyleNames="{style.labelStyle}"/>
Line 48: </g:VerticalPanel>
remove TWS
Line 49: </g:HorizontalPanel>
Line 50: <g:ScrollPanel
addStyleNames="{style.tablePanel}"
Line 51: ui:field="sPanel">
Line 52: <e:EntityModelCellTable
ui:field="rebalanceHostsTable" />
--
To view, visit http://gerrit.ovirt.org/20800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2957ba2c4bd1f6deb1ef444e28e8afdd8896f0b4
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
