Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: event message for rebalance and remove brick complete
......................................................................


Patch Set 11: Code-Review+1

(1 comment)

One minor comment

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
Line 38: 
Line 39: public class GlusterTaskUtils {
Line 40:     private static GlusterTaskUtils instance;
Line 41: 
Line 42:     protected GlusterAuditLogUtil logUtil = 
GlusterAuditLogUtil.getInstance();
Signature could be private static final
Line 43:     private static final String REBALANCE_IN_PROGRESS = "IN PROGRESS";
Line 44:     private static final String REMOVE_BRICK_FAILED = "MIGRATION 
FAILED";
Line 45:     private static final String REMOVE_BRICK_IN_PROGRESS = "MIGRATION 
IN PROGRESS";
Line 46:     private static final String REMOVE_BRICK_FINISHED = "MIGRATION 
COMPLETE";


-- 
To view, visit http://gerrit.ovirt.org/21080
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4da9730cd8c251bc5707df981204b092948fb6f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to