Sahina Bose has posted comments on this change.
Change subject: gluster: event message for rebalance and remove brick complete
......................................................................
Patch Set 12:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
Line 220: String vol = task.getTaskParameters().getVolumeName();
Line 221: GlusterVolumeEntity volume =
getVolumeDao().getByName(cluster.getId(), vol);
Line 222: if (JobExecutionStatus.ABORTED == task.getStatus() ||
JobExecutionStatus.FINISHED == task.getStatus() || JobExecutionStatus.FAILED ==
task.getStatus()){
Line 223: if(oldStatus != task.getStatus()){
Line 224: logMessage(volume.getClusterId(), volume ,
taskTypeStrMap.get(task.getType()), task.getStatus().name().toLowerCase(),
taskTypeAuditMsg.get(task.getType()));
Possible NPE on volume.getClusterId. Why don't you use cluster.getId instead?
Line 225: }
Line 226: }
Line 227: }
Line 228:
--
To view, visit http://gerrit.ovirt.org/21080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4da9730cd8c251bc5707df981204b092948fb6f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
