Allon Mureinik has posted comments on this change. Change subject: engine: Remove StorageType.ALL value ......................................................................
Patch Set 3: Code-Review+2 (1 comment) If you rebase, please fix the style issue in the upgrade scripts. Also, please verify. .................................................... File packaging/dbscripts/upgrade/03_04_0130_replace_storage_type_all_with_unknown.sql Line 1: update storage_domain_static set storage_type = 0 where storage_type = -1; Line 2: Line 3: update storage_pool set storage_pool_type = 0 where storage_pool_type = -1; I'd capitalize all the SQL reserved words: UPDATE storage_pool SET storage_pool_type = 0 WHERE storage_pool_type = -1; -- To view, visit http://gerrit.ovirt.org/21315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761d322f88304353bb11fceeed39305dd6698045 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
