Liron Ar has posted comments on this change. Change subject: engine: Remove StorageType.ALL value ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java Line 53: } Line 54: if (vg.containsKey("vgtype")) { Line 55: sDomain.setStorageType(EnumUtils.valueOf(StorageType.class, vg.get("vgtype").toString(), true)); Line 56: } else { Line 57: sDomain.setStorageType(StorageType.UNKNOWN); Regardles of upgrade script, i hope that older vdsm versions aren't using that value for anything..otherwise using new engine with "old" vdsm would cause to issues. Line 58: } Line 59: result.add(sDomain); Line 60: } Line 61: return result; -- To view, visit http://gerrit.ovirt.org/21315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761d322f88304353bb11fceeed39305dd6698045 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches