Sahina Bose has posted comments on this change. Change subject: engine: cleanup AddVdsCommand locking ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java Line 346 Line 347 Line 348 Line 349 Line 350 Thinking about this further, this check cannot really be moved to the post installation when vdsm is UP - as this would lead to a catch-22 like situation. If there's another Non-operational server, then no server can move to UP state. And since, there really is no point of a cluster, if the other servers are Non-operational, isn't it better to fail here? -- To view, visit http://gerrit.ovirt.org/18350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
