Alon Bar-Lev has posted comments on this change. Change subject: engine: cleanup AddVdsCommand locking ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java Line 346 Line 347 Line 348 Line 349 Line 350 question... what if you move this to post installation when vdsm is up? then if no other host is available, for example non responsive, host becomes non operational, but if problem is fixed then people can move to maintenance and back and have host active? this will also allow you to move the duplicate check to the point host is up as well, to make sure that every time host becomes up it belongs to the right gluster cluster. In nut shell... doing validation at installation time is one time, while doing validation when host becomes up is something that is always done. -- To view, visit http://gerrit.ovirt.org/18350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
