Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Support generic TextBoxLabel widget ......................................................................
Patch Set 2: Since we'd like to replace ValueLabel usage with TextBoxLabel usage in "General" sub tab views, TextBoxLabelBase should also have a constructor without parser parameter: public TextBoxLabelBase(Renderer<T> renderer) ... In this case, the default "get rendered text and parse it into typed representation" behavior of ValueBoxBase.getValueOrThrow method would be altered, i.e. using custom parser implementation that doesn't care about rendered text whatsoever and just returns the value of last call to setValue method. Long story short, I'll need to improve this patch a bit. -- To view, visit http://gerrit.ovirt.org/21289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728f7d6fdc74523ac397225c1c5833cb84f6eef9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
