[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Support generic TextBoxLabel widget

[awels]

Alexander Wels has posted comments on this change.

Change subject: webadmin,userportal: Support generic TextBoxLabel widget
......................................................................


Patch Set 4:

(1 comment)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabel.java
Line 18:         super(new EmptyValueRenderer<String>() {
Line 19:             @Override
Line 20:             public String render(String value) {
Line 21:                 String renderedText = super.render(value);
Line 22:                 renderedText = renderedText.replace("&lt;", "<"); 
//$NON-NLS-1$ //$NON-NLS-2$
What about &gt; and a bunch of other encoded string elements? wouldn't it make 
more sense to use a generic encoder/decoder?
Line 23:                 return renderedText;
Line 24:             }
Line 25:         });
Line 26:     }


-- 
To view, visit http://gerrit.ovirt.org/21289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728f7d6fdc74523ac397225c1c5833cb84f6eef9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches