Moti Asayag has posted comments on this change.
Change subject: core: [Fix] Add host hotplug support checks
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
We need to verify for nic plugging that the cluster supports the plugging
operation.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 393: return isHotPlugSupported() &&
isInterfaceSupportedForPlugUnPlug(disk);
Line 394: }
Line 395:
Line 396: protected boolean canPerformNicHotPlug() {
Line 397: return osRepository.hasNicHotplugSupport(getVm().getOs(),
getVm().getVdsGroupCompatibilityVersion());
Please add to this method the check for the cluster feature compatibility:
return isHotPlugSupported() &&
osRepository.hasNicHotplugSupport(getVm().getOs(),
getVm().getVdsGroupCompatibilityVersion());
Line 398: }
Line 399:
Line 400: /**
Line 401: * check that hotplug is enabled via the 3.1 config paramter
{@literal ConfigValues.HotPlugEnabled,
Line 403: */
Line 404: protected boolean isHotPlugSupported() {
Line 405: if
(FeatureSupported.hotPlug(getVds().getVdsGroupCompatibilityVersion())) {
Line 406: return true;
Line 407: }
Please replace the following 2 lines with
return failCanDoAction(VdcBllMessages.HOT_PLUG_IS_NOT_SUPPORTED);
Line 408:
addCanDoActionMessage(VdcBllMessages.HOT_PLUG_IS_NOT_SUPPORTED);
Line 409: return false;
Line 410: }
Line 411:
--
To view, visit http://gerrit.ovirt.org/21266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c8409c0de4ff1c959d27b54e793a31654326c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
