Moti Asayag has posted comments on this change.

Change subject: core: [Fix] Add host hotplug support checks
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 391:         return isHotPlugSupported() && isOsSupportingHotPlug();
Line 392:     }
Line 393: 
Line 394:     protected boolean canPerformNicHotPlug() {
Line 395:         return osRepository.hasNicHotplugSupport(getVm().getOs(), 
getVm().getVdsGroupCompatibilityVersion());
thanks for clarifying it.
Line 396:     }
Line 397: 
Line 398:     /**
Line 399:      * check that hotplug is enabled via the 3.1 config paramter 
{@literal ConfigValues.HotPlugEnabled,


-- 
To view, visit http://gerrit.ovirt.org/21266
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c8409c0de4ff1c959d27b54e793a31654326c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa 
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to