Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster syncing lock correction
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 571:
Line 572: @Override
Line 573: protected Map<String, Pair<String, String>> getSharedLocks() {
Line 574: VDSGroup cluster = getVdsGroup();
Line 575: if (cluster != null && cluster.supportsGlusterService() &&
!isInternalExecution()) {
no need to check isInternal
Line 576: return
Collections.singletonMap(cluster.getId().toString(),
Line 577:
LockMessagesMatchUtil.makeLockingPair(LockingGroup.GLUSTER,
VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_OPERATION_INPROGRESS));
Line 578: }
Line 579: return null;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 280:
Line 281: @Override
Line 282: protected Map<String, Pair<String, String>> getSharedLocks() {
Line 283: VDSGroup cluster = getTargetCluster();
Line 284: if (cluster != null && cluster.supportsGlusterService() &&
!isInternalExecution()) {
no need to check isInternal
Line 285: return
Collections.singletonMap(cluster.getId().toString(),
Line 286:
LockMessagesMatchUtil.makeLockingPair(LockingGroup.GLUSTER,
VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_OPERATION_INPROGRESS));
Line 287: }
Line 288: return null;
--
To view, visit http://gerrit.ovirt.org/20647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe28b5eb5baee573f0fa875e06d7ae945ffdb9f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
