Allon Mureinik has posted comments on this change.

Change subject: core: Make commited_disk_size view column show total virtual 
size
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
Line 152:             
entity.setStorageDomainType(StorageDomainType.forValue(rs.getInt("storage_domain_type")));
Line 153:             
entity.setStorageFormat(StorageFormatType.forValue(rs.getString("storage_domain_format_type")));
Line 154:             entity.setAvailableDiskSize((Integer) 
rs.getObject("available_disk_size"));
Line 155:             entity.setUsedDiskSize((Integer) 
rs.getObject("used_disk_size"));
Line 156:             
entity.setCommittedDiskSize(rs.getInt("actual_images_size"));
This should be entity.setActualImagesSize
Line 157:             
entity.setCommittedDiskSize(rs.getInt("commited_disk_size"));
Line 158:             
entity.setStatus(StorageDomainStatus.forValue(rs.getInt("status")));
Line 159:             entity.setStorageDomainSharedStatus(
Line 160:                     
StorageDomainSharedStatus.forValue(rs.getInt("storage_domain_shared_status")));


....................................................
File packaging/dbscripts/create_functions.sql
Line 350: BEGIN
Line 351:       mult := ( SELECT
Line 352:                       COALESCE(SUM(images_storage_domain_view.size),0)
Line 353:                               FROM images_storage_domain_view
Line 354:                               WHERE
please drop the newline here.
Line 355:                                       
images_storage_domain_view.storage_id = v_storage_domain_id );
Line 356:         -- convert to GB from bytes
Line 357:       mult := CAST((mult * 0.000000000931322574615478515625) AS 
bigint);
Line 358:     result := CAST(mult as integer);


-- 
To view, visit http://gerrit.ovirt.org/20930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to