Alexander Wels has posted comments on this change. Change subject: branding: Allow templates to be replaced ......................................................................
Patch Set 2: (1 comment) .................................................... Commit Message Line 9: - Allowed themes the ability to override the default behaviour of Line 10: append their templates to previous template. This allows themes Line 11: to almost completely replace the entire welcome page. Line 12: - Removed requirement that style sheet files must be defined in Line 13: branding.properties. Fair enough, reverted this, and added a check to make sure if welcome_replace is provided but not true/false it will fail to load the theme. Line 14: Line 15: Change-Id: Id3376500d1ceece80132089d90174e092992d36d -- To view, visit http://gerrit.ovirt.org/21195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3376500d1ceece80132089d90174e092992d36d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
