Alon Bar-Lev has posted comments on this change.
Change subject: branding: Allow templates to be replaced
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java
Line 247: return result;
Line 248: }
Line 249:
Line 250: public boolean shouldReplaceWelcomePageSectionTemplate() {
Line 251: return
Boolean.valueOf(brandingProperties.getProperty(REPLACE_TEMPLATE_KEY));
as far as I saw from documentation it is only "true" that is accepted.
I really do not like ignoring invalid values in a file, if I have spelling
mistake of the true then I get false.
I do like 0|1... but I was afraid to suggest this as only alternative...
Line 252: }
Line 253:
Line 254: /**
Line 255: * Return the raw welcome template as a string.
--
To view, visit http://gerrit.ovirt.org/21195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3376500d1ceece80132089d90174e092992d36d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
