Kanagaraj M has posted comments on this change.
Change subject: engine: Populate jobId on gluster async task
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivitySeperatorCell.java
Line 33: public void render(Context context, T value, SafeHtmlBuilder sb) {
Line 34: if (value == null || value.getAsyncTask() == null ||
value.getAsyncTask().getStatus() == null
Line 35: || value.getAsyncTask().getStatus() ==
JobExecutionStatus.UNKNOWN) {
Line 36: return;
Line 37: }
does this check required? Outer composite is hidden anyway in these cases
Line 38:
Line 39: SafeHtml separatorImageHtml =
Line 40:
SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(imageResources.separator()).getHTML());
Line 41: sb.append(separatorImageHtml);
--
To view, visit http://gerrit.ovirt.org/21120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e1eebe89dd455a5afa85b6747f11ddc5cafb146
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
