Kanagaraj M has posted comments on this change.
Change subject: engine: Populate jobId on gluster async task
......................................................................
Patch Set 4:
(2 comments)
Changes to Bricks sub-tab is missing.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeTaskCompositeCell.java
Line 10: import com.google.gwt.cell.client.HasCell;
Line 11: import com.google.gwt.dom.client.Element;
Line 12: import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
Line 13:
Line 14: public class VolumeTaskCompositeCell<T extends GlusterTaskSupport>
extends CompositeCell<T> {
I see around 80% of code is same in VolumeTaskCompositeCell and
VolumeActivityCompositeCell.
Is is possible to move the common parts to a new super class?
Line 15:
Line 16: private final List<HasCell<T, ?>> hasCells;
Line 17:
Line 18: public VolumeTaskCompositeCell(List<HasCell<T, ?>> hasCells) {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeTaskWaitingCell.java
Line 23: ApplicationTemplates applicationTemplates =
ClientGinjectorProvider.getApplicationTemplates();
Line 24:
Line 25: @Override
Line 26: public void render(Context context, T value, SafeHtmlBuilder sb) {
Line 27: // Waiting icon need to be rendered only if job is started and
task ref is emptu
empty
Line 28: if (value.getAsyncTask() == null ||
value.getAsyncTask().getJobId() == null
Line 29: || value.getAsyncTask().getType() != null
Line 30: || value.getAsyncTask().getJobStatus() !=
JobExecutionStatus.STARTED) {
Line 31: return;
--
To view, visit http://gerrit.ovirt.org/21120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e1eebe89dd455a5afa85b6747f11ddc5cafb146
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
