Alex Lourie has posted comments on this change. Change subject: packaging: setup: update DB configuration reading ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/ovirt-engine-reports-setup.py Line 291: 'Please execute: \"engine-setup\" followed by ' Line 292: '\"ovirt-engine-dwh-setup\" ' Line 293: 'before setting up the reports.' Line 294: ) Line 295: 1. The reports package depends on dwh package 2. The new dwh patch (related to this one) always brings dwh config file 3. If the file doesn't exist, it means someone manually removed it Line 296: dwhandler = utils.TextConfigFileHandler(FILE_DATABASE_DWH_CONFIG) Line 297: dwhandler.open() Line 298: db_dict['dwh_database'] = dwhandler.getParam('DWH_DATABASE') Line 299: db_dict['dwh_user'] = dwhandler.getParam('DWH_USER') -- To view, visit http://gerrit.ovirt.org/21145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I430eee10a06fabeab24c9f4f240373a7b830878a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches