Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: update DB configuration reading
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File packaging/ovirt-engine-reports-setup.py
Line 291: db_dict['dwh_database'] =
dwhandler.getParam('DWH_DATABASE')
Line 292: db_dict['dwh_user'] = dwhandler.getParam('DWH_USER')
Line 293: db_dict['dwh_pass'] = dwhandler.getParam('DWH_PASSWORD')
Line 294:
Line 295: if db_dict is None:
This condition is True only if FILE_DATABASE_CONFIG is missing. It doesn't
check for dwh configuration.
Line 296: raise RuntimeError(
Line 297: 'Engine and/or DWH were not setup on this machine. '
Line 298: 'Please execute: \"engine-setup\" and
\"ovirt-engine-dwh-setup\" '
Line 299: 'before setting up the reports.'
--
To view, visit http://gerrit.ovirt.org/21145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I430eee10a06fabeab24c9f4f240373a7b830878a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
