Kanagaraj M has posted comments on this change.
Change subject: engine: Clean up orphan gluster task references
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 378: List<Step> steps =
getStepDao().getStepsByExternalId(taskId);
Line 379: for (Step step: steps) {
Line 380: step.markStepEnded(JobExecutionStatus.UNKNOWN);
Line 381: endStepJob(step);
Line 382: }
Volume will be still up even though all the bricks are down.
But as you stated, if you are cleaning up the orphan tasks in case of gluster
command failure, it should be fine
Line 383: releaseVolumeLock(taskId);
Line 384: }
Line 385:
Line 386: }
--
To view, visit http://gerrit.ovirt.org/20954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61f921109fb710dfb3f7255b54595c882c6a076c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
