Sahina Bose has posted comments on this change.
Change subject: engine: Clean up orphan gluster task references
......................................................................
Patch Set 2:
(2 comments)
Updated patchset to follow
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 97: {
Line 98: return null;
Line 99: }
Line 100:
Line 101: Map<Guid, GlusterAsyncTask> runningTasks =
getProvider().getTaskListForCluster(cluster.getId());
Done
Line 102:
Line 103: if (runningTasks == null) {
Line 104: return null;
Line 105: }
Line 378: List<Step> steps =
getStepDao().getStepsByExternalId(taskId);
Line 379: for (Step step: steps) {
Line 380: step.markStepEnded(JobExecutionStatus.UNKNOWN);
Line 381: endStepJob(step);
Line 382: }
If glusterd has crashed on one of the nodes in the cluster, gluster would still
return status from other nodes. Only in case where all bricks of volume are on
the node where glusterd crashed, would the task information not be returned. In
that case, the volume would be down, no?
Also changed code to not clean orphan tasks, in case VDSM call has not
succeeded, to ensure engine does not remove tasks that actually exist.
Line 383: releaseVolumeLock(taskId);
Line 384: }
Line 385:
Line 386: }
--
To view, visit http://gerrit.ovirt.org/20954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61f921109fb710dfb3f7255b54595c882c6a076c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
