Omer Frenkel has posted comments on this change.
Change subject: core: increase AutoStartVmsRunner job frequency
......................................................................
Patch Set 8:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java
Line 51:
Line 52: autoStartVmsToRun.removeAll(idsToRemove);
Line 53: }
Line 54:
Line 55: private EngineLock createLockForRunVmCommand(Guid vmId) {
please extract lock logic to some shard place and use it also in run vm
command, so if it would change this will be sync'd
Line 56: return new EngineLock(
Line 57: Collections.singletonMap(
Line 58: vmId.toString(),
Line 59: LockMessagesMatchUtil.makeLockingPair(
--
To view, visit http://gerrit.ovirt.org/19499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0968cae554458f53a1f30643848bb8d88bd4de11
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
