Alon Bar-Lev has posted comments on this change. Change subject: engine: Add infrastructure code for removal of parameter classes ......................................................................
Patch Set 14: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/GenericVdcParameter.java Line 1: package org.ovirt.engine.core.common.utils; Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public class GenericVdcParameter { just a thought... if we create empty base class, for example: public class VdcParameterMeta {} and have all these classes inherit from it: public class GenericVdcParameter extends VdcParameterMeta { ... } will this ease in any way for people working in Eclipse and such to find these parameters classes? Maybe there is functionality to search for all classes of specific class in the UI... BTW: should this class be called GenericVdcParameter[s]? Line 6: Line 7: public final static VdcParameter GUID_ID = VdcParameter.create("GUID_ID", Guid.class, "82853410-f449-46a8-99bc-44e1330b8f3c"); Line 8: -- To view, visit http://gerrit.ovirt.org/20414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches