Alon Bar-Lev has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 14:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/InvalidParameterUuidException.java
Line 1: package org.ovirt.engine.core.common.utils;
Line 2:
Line 3: public class InvalidParameterUuidException extends
IllegalArgumentException {
Line 4:
Line 5: public InvalidParameterUuidException(String name, String uuid,
String existingName) {
won't it better to get UUID type?
Line 6: super("Invalid value for uuid " + uuid + " for Parameter " +
name +
Line 7: ". A parameter with the same uuid already exists " +
existingName);
Line 8: }
Line 9:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameter.java
Line 10: private final String name;
Line 11: private final Class javaType;
Line 12: private final UUID uuid;
Line 13: private static final Map<UUID, VdcParameter> parametersMap = new
HashMap<UUID, VdcParameter>();
Line 14: private static final int VERSION = 0;
not that it is important but I suggest adding prefix to constant groups, in
this case something like SERIALIZE_VERSION, SERIALIZE_VERSION_KEY,
SERIALIZE_UUID_KEY
Line 15: private static final String VERSION_KEY = "version";
Line 16: private static final String UUID_KEY = "uuid";
Line 17:
Line 18: private VdcParameter(String name, Class javaType, UUID guid) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParametersMap.java
now... a simple stupid question.... I delayed it as much as I could... and I
cannot any more.... :)
can this object inherit from map? and actually be a map with our ability to
check in coming and outgoing types?
I mean instead of having a map as member.
Line 1: package org.ovirt.engine.core.common.utils;
Line 2:
Line 3: import java.io.Serializable;
Line 4: import java.util.Collections;
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
