Alexander Wels has posted comments on this change. Change subject: utils: pki-resource: cleanup: levarage enum for constants ......................................................................
Patch Set 7: Two things I don't agree with at this point: 1. The code that generates the output format string is in the resources. It is a function of the output type and should be associated with that. 2. As a consequence of that the alias should be part of the output type as well. Only OPENSSH_PUBKEY is related to alias at this point, but for some reason it is part of the Resource enum. -- To view, visit http://gerrit.ovirt.org/21073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24da0ff174599ffdeabbf5846eab429bf0d6510d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
