Alon Bar-Lev has posted comments on this change. Change subject: utils: pki-resource: cleanup: levarage enum methods for content type ......................................................................
Patch Set 6: > I understand now what you were saying about format vs resources. I reworked > it a little bit and it is now more or less the same as you had before just > tidier. Right... just exactly the opposite... I would have added the conversion to string to resource and not at the format, not that complex to modify. Still there is a dependency between implementation and public protocol, which I do not approve. And there is the loading of certificate at static context, which you asked to avoid... and because of that I added the Details structure. So I am confused.... 1. solving the static context issue derives using the Details at constructor. 2. keeping public protocol intact derives mapping at servlet. 3. if (1) request is removed, we can go with enum but I would not remove (2)... -- To view, visit http://gerrit.ovirt.org/21073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24da0ff174599ffdeabbf5846eab429bf0d6510d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
