Omer Frenkel has posted comments on this change. Change subject: core:there are dos end of lines in engine.log ......................................................................
Patch Set 1: actually these logs are old and redundent, and can be removed completely, as now we have infrastructure to log all VDS commands parameters, looking at the log it seems that we are missing 'volumeType' info in both. for example this is what the infra provide for create snapshot: 2013-11-07 10:35:57,172 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.CreateSnapshotVDSCommand] (org.ovirt.thread.pool-6-thread-28) [1df7e219] START, CreateSnapshotVDSCommand( storagePoolId = 03c4bba0-f23d-41b2-a378-aec15ec0bd41, ignoreFailoverLimit = false, storageDomainId = 46d8463c-0168-4c94-a34d-b662b8eb7d70, imageGroupId = c34c46cb-a8c0-47e1-9b2b-d11ac76d4fb4, imageSizeInBytes = 1073741824, volumeFormat = COW, newImageId = f9f6f7c4-a79e-4dbc-a8d3-b0f4144cbe7d, newImageDescription = , imageId = c430a34d-5c0b-4260-b830-6f2b91e3ad27, sourceImageGroupId = c34c46cb-a8c0-47e1-9b2b-d11ac76d4fb4), log id: 38ae1f7f -- To view, visit http://gerrit.ovirt.org/20983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73eae1a3d76ffca00089ace3e9fc371950da30ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
