Eli Mesika has posted comments on this change. Change subject: core:there are dos end of lines in engine.log ......................................................................
Patch Set 1: (2 comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java Line 27: getParameters().getImageType().name(), Line 28: getParameters().getNewImageID().toString(), Line 29: getParameters().getNewImageDescription(), Line 30: Guid.Empty.toString(), Line 31: Guid.Empty.toString()); Removed call (see Omer comment) Line 32: Line 33: // NOTE: The 'uuidReturn' variable will contain the taskID and not the Line 34: // created image id! Line 35: uuidReturn = getIrsProxy().createVolume( .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java Line 27: getParameters().getImageType().name(), Line 28: getParameters().getNewImageID().toString(), Line 29: getParameters().getNewImageDescription(), Line 30: getParameters().getSourceImageGroupId().toString(), Line 31: getParameters().getImageId().toString()); Removed call (see Omer comment) Line 32: Line 33: // NOTE: The 'uuidReturn' variable will contain the taskID and not Line 34: // the created image id! Line 35: uuidReturn = getIrsProxy().createVolume(getParameters().getStorageDomainId().toString(), -- To view, visit http://gerrit.ovirt.org/20983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73eae1a3d76ffca00089ace3e9fc371950da30ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
