Mike Kolesnik has posted comments on this change. Change subject: engine: Clear few eclipse warnings ......................................................................
Patch Set 1: Code-Review+2 (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java Line 163: // is on Line 164: List<VmStatic> vmsToMigrate = Line 165: DbFacade.getInstance().getVmStaticDao().getAllWithFailbackByVds(vds.getId()); Line 166: if (vmsToMigrate.size() > 0) { Line 167: ArrayList<VdcActionParametersBase> vmToServerParametersList = Perhaps change reference type to List while you're at it? Line 168: new ArrayList<VdcActionParametersBase>(LinqUtils Line 169: .foreach(vmsToMigrate, new Function<VmStatic, VdcActionParametersBase>() { Line 170: @Override Line 171: public VdcActionParametersBase eval(VmStatic vm) { -- To view, visit http://gerrit.ovirt.org/20989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic157218e286586a448013019b01912918b5ff606 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches