Moti Asayag has uploaded a new change for review.
Change subject: engine: Clear few eclipse warnings
......................................................................
engine: Clear few eclipse warnings
Change-Id: Ic157218e286586a448013019b01912918b5ff606
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
3 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/20989/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java
index ccb3d3d..310fc61 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java
@@ -7,7 +7,7 @@
import org.ovirt.engine.core.dal.dbbroker.DbFacade;
public class UpdateBookmarkCommand<T extends BookmarksOperationParameters>
- extends BookmarkOperationCommand {
+ extends BookmarkOperationCommand<T> {
public UpdateBookmarkCommand(T parameters) {
super(parameters);
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
index c8a1610..bacb7ac 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
@@ -165,7 +165,7 @@
DbFacade.getInstance().getVmStaticDao().getAllWithFailbackByVds(vds.getId());
if (vmsToMigrate.size() > 0) {
ArrayList<VdcActionParametersBase>
vmToServerParametersList =
- new ArrayList(LinqUtils
+ new
ArrayList<VdcActionParametersBase>(LinqUtils
.foreach(vmsToMigrate, new
Function<VmStatic, VdcActionParametersBase>() {
@Override
public VdcActionParametersBase
eval(VmStatic vm) {
diff --git
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
index 29dd4bc..cac0bbb 100644
---
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
+++
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
@@ -61,7 +61,7 @@
@Test
public void insufficientDiskSpace() {
final int lotsOfSpace = 1073741824;
- final ImportVmCommand c = setupDiskSpaceTest(lotsOfSpace);
+ final ImportVmCommand<ImportVmParameters> c =
setupDiskSpaceTest(lotsOfSpace);
assertFalse(c.canDoAction());
assertTrue(c.getReturnValue()
.getCanDoActionMessages()
@@ -71,14 +71,14 @@
@Test
public void sufficientDiskSpace() {
final int extraDiskSpaceRequired = 0;
- final ImportVmCommand c = setupDiskSpaceTest(extraDiskSpaceRequired);
+ final ImportVmCommand<ImportVmParameters> c =
setupDiskSpaceTest(extraDiskSpaceRequired);
assertTrue(c.canDoAction());
}
- private ImportVmCommand setupDiskSpaceTest(final int diskSpaceRequired) {
+ private ImportVmCommand<ImportVmParameters> setupDiskSpaceTest(final int
diskSpaceRequired) {
mcr.mockConfigValue(ConfigValues.FreeSpaceCriticalLowInGB,
diskSpaceRequired);
- ImportVmCommand<ImportVmParameters> cmd = spy(new
ImportVmCommand(createParameters()));
+ ImportVmCommand<ImportVmParameters> cmd = spy(new
ImportVmCommand<ImportVmParameters>(createParameters()));
doReturn(true).when(cmd).validateNoDuplicateVm();
doReturn(true).when(cmd).validateVdsCluster();
doReturn(true).when(cmd).validateUsbPolicy();
@@ -232,7 +232,7 @@
public void testAliasGenerationByAddVmImagesAndSnapshotsWithCollapse() {
ImportVmParameters params = createParameters();
params.setCopyCollapse(true);
- ImportVmCommand cmd = spy(new ImportVmCommand(params));
+ ImportVmCommand<ImportVmParameters> cmd = spy(new
ImportVmCommand<ImportVmParameters>(params));
DiskImage collapsedDisk = params.getVm().getImages().get(1);
@@ -252,7 +252,7 @@
params.setCopyCollapse(Boolean.TRUE);
DiskImage diskImage = params.getVm().getImages().get(0);
diskImage.setVmSnapshotId(Guid.Empty);
- ImportVmCommand cmd = spy(new ImportVmCommand(params));
+ ImportVmCommand<ImportVmParameters> cmd = spy(new
ImportVmCommand<ImportVmParameters>(params));
doReturn(true).when(cmd).validateNoDuplicateVm();
doReturn(true).when(cmd).validateVdsCluster();
doReturn(true).when(cmd).validateUsbPolicy();
@@ -275,7 +275,7 @@
public void testAliasGenerationByAddVmImagesAndSnapshotsWithoutCollapse() {
ImportVmParameters params = createParameters();
params.setCopyCollapse(false);
- ImportVmCommand cmd = spy(new ImportVmCommand(params));
+ ImportVmCommand<ImportVmParameters> cmd = spy(new
ImportVmCommand<ImportVmParameters>(params));
for (DiskImage image : params.getVm().getImages()) {
doNothing().when(cmd).saveImage(image);
--
To view, visit http://gerrit.ovirt.org/20989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic157218e286586a448013019b01912918b5ff606
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
