Lior Vernia has posted comments on this change.
Change subject: webadmin: cpu pinning is disabled for Local SD
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 701: compatibilityVersion))) {
Line 702: hasCpuPinning = false;
Line 703: } else if
(Boolean.FALSE.equals(AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.CpuPinMigrationEnabled,
Line 704:
AsyncDataProvider.getDefaultConfigurationVersion()))
Line 705: && isVmMigratable()) {
I'm assuming that in a local storage domain this can never be true? Otherwise
the added change prohibition reason isn't quite right.
Line 706: hasCpuPinning = false;
Line 707: }
Line 708:
Line 709: if (!hasCpuPinning) {
--
To view, visit http://gerrit.ovirt.org/20591
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4706419295d67f7a022a85bc61f75bb46def2b6b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
