Lior Vernia has posted comments on this change.
Change subject: webadmin: cpu pinning is disabled for Local SD
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 705: && isVmMigratable()) {
Line 706: hasCpuPinning = false;
Line 707: }
Line 708:
Line 709: if (!hasCpuPinning) {
The message should be updated to reflect the change. And actually, it might be
a good idea to split it into several message, so that in each case the user
would know exactly what caused the widget to be disabled, rather then list all
possible reasons.
Line 710:
getModel().getCpuPinning().setChangeProhibitionReason(constants.cpuPinningUnavailable());
Line 711: getModel().getCpuPinning().setEntity("");
Line 712: }
Line 713: getModel().getCpuPinning().setIsChangable(hasCpuPinning);
--
To view, visit http://gerrit.ovirt.org/20591
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4706419295d67f7a022a85bc61f75bb46def2b6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
