Alon Bar-Lev has posted comments on this change. Change subject: ovirt-live fix makefile iso path ......................................................................
Patch Set 4: (2 comments) .................................................... File centos/Makefile Line 58: "$<" > "$@" Line 59: Line 60: livecd: \ Line 61: repo \ Line 62: oVirtLiveFiles/iso/TinyCore-current.iso \ I am unsure how it works for you... as you do not have rule for this ^ Line 63: kickstart/ovirt-live-base.ks \ Line 64: $(NULL) Line 65: mv downloads/TinyCore-current.iso oVirtLiveFiles/iso/ Line 61: repo \ Line 62: oVirtLiveFiles/iso/TinyCore-current.iso \ Line 63: kickstart/ovirt-live-base.ks \ Line 64: $(NULL) Line 65: mv downloads/TinyCore-current.iso oVirtLiveFiles/iso/ copy, don't move. also, don't you need to create the iso directory? -- To view, visit http://gerrit.ovirt.org/20500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I915d26aaeac14145f316ff9fa5cb1b71e7811327 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
