Alon Bar-Lev has posted comments on this change. Change subject: ovirt-live fix makefile iso path ......................................................................
Patch Set 2: (3 comments) .................................................... File centos/Makefile Line 12: dist-clean: clean Line 13: Line 14: maintainer-clean: dist-clean Line 15: rm -fr downloads Line 16: rm -rf oVirtLiveFiles/iso this is needed at regular clean, as the download which is the log process is kept Line 17: Line 18: prereq: Line 19: if [ $$(id -u) != 0 ]; then echo "You must be root"; exit 1; fi Line 20: Line 24: $(NULL) Line 25: Line 26: _download: Line 27: mkdir -p downloads Line 28: mkdir -p oVirtLiveFiles/iso this is not needed here Line 29: rm -f "downloads/$(OUT)" Line 30: curl "$(URL)" > "downloads/$(OUT).tmp" Line 31: mv "downloads/$(OUT).tmp" "downloads/$(OUT)" Line 32: Line 34: $(MAKE) _download URL="http://kojipkgs.fedoraproject.org//packages/yad/0.14.2/1.fc14/x86_64/yad-0.14.2-1.fc14.x86_64.rpm"; OUT="yad-0.14.2-1.fc14.x86_64.rpm" Line 35: Line 36: downloads/TinyCore-current.iso: Line 37: $(MAKE) _download URL="http://distro.ibiblio.org/tinycorelinux/4.x/x86/release/TinyCore-current.iso"; OUT="TinyCore-current.iso" Line 38: mv downloads/TinyCore-current.iso oVirtLiveFiles/iso/ copy not move and not in download phase... add your own or even in livecd phase Line 39: Line 40: Line 41: repo: \ Line 42: downloads/yad-0.14.2-1.fc14.x86_64.rpm \ -- To view, visit http://gerrit.ovirt.org/20500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I915d26aaeac14145f316ff9fa5cb1b71e7811327 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
