Martin Peřina has posted comments on this change.

Change subject: [WIP] engine : 998980 Generic mechanism for update diffs in 
audit
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 833: 
Line 834:     //mom policies
Line 835:     USER_UPDATED_MOM_POLICIES(10200),
Line 836:     USER_FAILED_TO_UPDATE_MOM_POLICIES(10201),
Line 837:     UPDATE_PARAMS(11100)
Eli, wouldn't it be better to put this to already existing general section 
after ENTITY_RENAME(1200) with id 1201 as I suggested?
Line 838:     ;
Line 839: 
Line 840:     private int intValue;
Line 841:     // indicates time interval in seconds on which identical events 
from same instance are supressed.


-- 
To view, visit http://gerrit.ovirt.org/20265
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3362f9bfffe921df44103239ece8348001feca5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to