Eli Mesika has posted comments on this change.
Change subject: [WIP] engine : 998980 Generic mechanism for update diffs in
audit
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1323:
Line 1324: void logCommand() {
Line 1325: Class<?> type = getClass();
Line 1326: InternalCommandAttribute annotation =
type.getAnnotation(InternalCommandAttribute.class);
Line 1327: if (annotation == null) {
In second thought , not needed ....
Line 1328: if (UpdateValuesProvider.class.isInstance(this)) {
Line 1329: UpdateValuesProvider<?> provider =
(UpdateValuesProvider<?>) this;
Line 1330: List<String> list =
GetChangedFields(provider.getOldObject(), provider.getNewObject());
Line 1331: Map<String, String> oldValues =
getValues(provider.getOldObject(), list);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
Line 119: }
Line 120:
Line 121: @Override
Line 122: public StorageDomain getOldObject() {
Line 123: return
DbFacade.getInstance().getStorageDomainDao().get(getStorageDomain().getId());
I see that the parameters class for this command has getStorageDomain that
returns the same type
Line 124: }
Line 125:
Line 126: @Override
Line 127: public StorageDomain getNewObject() {
--
To view, visit http://gerrit.ovirt.org/20265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3362f9bfffe921df44103239ece8348001feca5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
