Cheryn Tan has posted comments on this change. Change subject: backend: [wip] add a new specific VDS_CONNECTION_ERROR ......................................................................
Patch Set 1: (1 comment) Made a suggestion, but if it's not accurate I'll propose alternate messages. .................................................... File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties Line 202: IRS_REPOSITORY_NOT_FOUND=Error connecting to the Storage Pool Manager service.\nPossible reasons:\n - Storage Pool Manager service is in non-active state.\n - No Active Host in the Data Center. Line 203: MAC_POOL_INITIALIZATION_FAILED=Error Initializing MAC Pool Line 204: VDS_FENCING_OPERATION_FAILED=Host Fencing operation failed. Line 205: VDS_NETWORK_ERROR=Network error during communication with the Host. Line 206: VDS_CONNECTION_ERROR=Network error during the connection with the host It doesn't clearly illustrate the difference between VDS_NETWORK_ERROR and VDS_CONNECTION_ERROR as both error messages sound similar on face value. How about something more specific like "Request was not received by VDSM. Check the host connection and try again." (happy to continue workshopping if this is not accurate) Line 207: DeviceNotFound=Device not found or not accessible Line 208: CannotModifyVolumeTime=Cannot change volume's modify time Line 209: CannotDeleteVolume=Volume deletion error Line 210: CannotDeleteSharedVolume=Shared Volume cannot be deleted -- To view, visit http://gerrit.ovirt.org/20301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac5e6fa1d7113e6a478f6beb98066b35b2785e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
