Allon Mureinik has posted comments on this change.
Change subject: backend: [wip] add a new specific VDS_CONNECTION_ERROR
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
see inline
....................................................
Commit Message
Line 3: AuthorDate: 2013-10-18 00:00:50 +0200
Line 4: Commit: Federico Simoncelli <fsimo...@redhat.com>
Line 5: CommitDate: 2013-10-18 19:04:13 +0200
Line 6:
Line 7: backend: [wip] add a new specific VDS_CONNECTION_ERROR
+1.
Line 8:
Line 9: At the moment VDS_NETWORK_ERROR is used both for timeouts and connection
Line 10: errors. The assumption is that when a VDS_NETWORK_ERROR is encountered
Line 11: the backend does't know if the request reached VDSM or not.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1508: if (rootCause == null) {
Line 1509: LoggedUtils.logError(log,
LoggedUtils.getObjectId(this), this, ex);
Line 1510: } else {
Line 1511: logException(rootCause);
Line 1512: if (rootCause.getClass() ==
ConnectException.class) {
please use isAssignableFrom instead of == - its safer if the JDK ever decides
to subclass this exception, or if we change our transport library.
Line 1513: vdcBllError =
VdcBllErrors.VDS_CONNECTION_ERROR;
Line 1514: }
Line 1515: }
Line 1516: getVDSReturnValue().setVdsError(new
VDSError(vdcBllError, ex.getMessage()));
--
To view, visit http://gerrit.ovirt.org/20301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac5e6fa1d7113e6a478f6beb98066b35b2785e5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
