Allon Mureinik has posted comments on this change.
Change subject: webadmin: edit unattached SD - prevent infinite progress
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
Line 568: // On Edit of active storage - only SPM is available. In edit
of storage in maintenance,
Line 569: //any host can perform the operation, thus no need to filter
to use just the SPM
Line 570: if (getStorage() != null && getStorage().getStatus() !=
StorageDomainStatus.Maintenance) {
Line 571: VDS spm = getSPM(hosts);
Line 572: hosts = spm != null ? Collections.singletonList(spm) :
new ArrayList<VDS>();
Why not return Collections.emptyList() ?
Line 573: }
Line 574:
Line 575: // Try to select previously selected host.
Line 576: if (oldSelectedItem != null) {
--
To view, visit http://gerrit.ovirt.org/20326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4b040ab1de8db42f43defbad0396ef4013572e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
