Daniel Erez has uploaded a new change for review. Change subject: webadmin: edit unattached SD - prevent infinite progress ......................................................................
webadmin: edit unattached SD - prevent infinite progress StorageModel -> postUpdateHost: When editing a storage domain, hosts are filtered according to the SPM. If no SPM is found, 'hosts' list can simply be set to an empty list (instead of a list with a single null object; which causes an NPE later on). Change-Id: Iad4b040ab1de8db42f43defbad0396ef4013572e Bug-Url: https://bugzilla.redhat.com/1017182 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/20326/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java index d2385f1..e5827b5 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java @@ -568,7 +568,8 @@ // On Edit of active storage - only SPM is available. In edit of storage in maintenance, //any host can perform the operation, thus no need to filter to use just the SPM if (getStorage() != null && getStorage().getStatus() != StorageDomainStatus.Maintenance) { - hosts = Collections.singletonList(getSPM(hosts)); + VDS spm = getSPM(hosts); + hosts = spm != null ? Collections.singletonList(spm) : new ArrayList<VDS>(); } // Try to select previously selected host. -- To view, visit http://gerrit.ovirt.org/20326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad4b040ab1de8db42f43defbad0396ef4013572e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
